Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add netcoreapp3.1 and net5.0 to AspNetCore project #2423

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Sep 22, 2021

Fix Issue #2251 .

As part of our depreciation of NetCoreApp2.1, we want to use FrameworkReferences in the AspNetCore project.
Due to some breaking changes, this is turning into a larger effort than expected. (#2412).
I'm breaking this into smaller tasks.
First, Adding NetCoreApp3.1 and Net5.0 to the AspNetCore project.
This change requires that I add the PublicApi files and will help guarantee that I'm not breaking any public apis.

Changes

  • Add NetCoreApp3.1 and Net5.0 to the AspNetCore project.
    • Adding new PublicApi files.
    • In follow up PR, will change these frameworks to use FrameworkReference
  • Keep NetStandard2.0.
  • Revert changes to AspNetCore.Test project. Need this for backwards compat testing.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra enabled auto-merge (squash) September 22, 2021 20:57
@TimothyMothra TimothyMothra merged commit c1c11cc into develop Sep 22, 2021
@TimothyMothra TimothyMothra deleted the tilee/aspnetcore_addFrameworks branch September 22, 2021 21:00
TimothyMothra added a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants